gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-265] remove AppMasterRuntime...
Date Mon, 23 Jan 2017 02:40:12 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97245558
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
    @@ -142,4 +138,25 @@ case class ExecutorContext(
     case class ExecutorJVMConfig(
         classPath: Array[String], jvmArguments: Array[String], mainClass: String,
         arguments: Array[String], jar: Option[AppJar], username: String,
    -    executorAkkaConfig: Config = ConfigFactory.empty())
    \ No newline at end of file
    +    executorAkkaConfig: Config = ConfigFactory.empty())
    +
    +sealed abstract class ApplicationStatus(val status: String, val isTerminal: Boolean)
    --- End diff --
    
    We can have a `TerminalStatus` extending `ApplicationStatus` for pattern matching rather
than checking the flag every time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message