gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-265] remove AppMasterRuntime...
Date Mon, 23 Jan 2017 02:28:38 GMT
Github user manuzhang commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
    @@ -18,17 +18,21 @@
     package org.apache.gearpump.cluster.client
     import akka.pattern.ask
    +import{Actor, ActorRef, ActorSystem, Props}
     import akka.util.Timeout
    -import org.apache.gearpump.cluster.ClientToMaster.{ResolveAppId, ShutdownApplication}
    -import org.apache.gearpump.cluster.MasterToClient.{ResolveAppIdResult, ShutdownApplicationResult}
    +import org.apache.gearpump.cluster.ClientToMaster.{RegisterAppResultListener, ResolveAppId,
    +import org.apache.gearpump.cluster.MasterToClient.{ApplicationResult, ResolveAppIdResult,
    +import org.apache.gearpump.cluster.client.RunningApplication.{AppResultListener, WaitUntilFinish}
     import org.apache.gearpump.util.ActorUtil
    +import org.apache.gearpump.cluster.client.RunningApplication._
    -import scala.concurrent.Future
    +import scala.concurrent.duration._
    +import scala.concurrent.{Await, Future}
     import scala.util.{Failure, Success}
    -class RunningApplication(val appId: Int, master: ActorRef, timeout: Timeout) {
    +class RunningApplication(val appId: Int, master: ActorRef, timeout: Timeout,
    +    system: ActorSystem) {
    --- End diff --
    Can we avoid passing `system` around ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message