gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #133: [GEARPUMP-252] return meaningful resul...
Date Wed, 18 Jan 2017 02:28:26 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/133#discussion_r96557102
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala ---
    @@ -53,20 +55,21 @@ class ClientContext(config: Config, sys: ActorSystem, _master: ActorRef)
{
       }
     
       private val LOG: Logger = LogUtil.getLogger(getClass)
    -  private implicit val timeout = Timeout(5, TimeUnit.SECONDS)
    -
       implicit val system = Option(sys).getOrElse(ActorSystem(s"client${Util.randInt()}",
config))
       LOG.info(s"Starting system ${system.name}")
    -  val shouldCleanupSystem = Option(sys).isEmpty
    -
    +  private val shouldCleanupSystem = Option(sys).isEmpty
    --- End diff --
    
    The `system` won't be empty but `sys` can still be empty. `sys` not being empty means
user has provided a ActorSystem so clientcontext should clean up user's actor system when
being closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message