gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #133: [GEARPUMP-252] return meaningful resul...
Date Wed, 18 Jan 2017 02:05:40 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/133#discussion_r96553343
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala ---
    @@ -35,14 +36,15 @@ import org.slf4j.Logger
     import scala.collection.JavaConverters._
     import scala.concurrent.duration.Duration
     import scala.concurrent.{Await, Future}
    -import scala.util.Try
    +import scala.util.{Failure, Success, Try}
     
     /**
      * ClientContext is a user facing util to submit/manage an application.
      *
      * TODO: add interface to query master here
      */
     class ClientContext(config: Config, sys: ActorSystem, _master: ActorRef) {
    +  import scala.concurrent.ExecutionContext.Implicits.global
    --- End diff --
    
    better put this in the headers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message