gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #131: [GEARPUMP-262] Add setup and teardown ...
Date Fri, 13 Jan 2017 08:36:49 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/131#discussion_r95955067
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/javaapi/JavaStream.scala
---
    @@ -31,23 +31,23 @@ import org.apache.gearpump.streaming.task.Task
     class JavaStream[T](val stream: Stream[T]) {
     
       /** FlatMap on stream */
    -  def flatMap[R](fn: FlatMapFunction[T, R], description: String): JavaStream[R] = {
    -    new JavaStream[R](stream.flatMap({ t: T => fn(t).asScala }, description))
    +  def flatMap[R](fn: functions.FlatMapFunction[T, R], description: String): JavaStream[R]
= {
    +    new JavaStream[R](stream.flatMap(FlatMapFunction(fn), "flatMap"))
    --- End diff --
    
    FlatMapFunction(fn: FlatMapFunction) is kind of weird 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message