gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #131: [GEARPUMP-262] Add setup and teardown ...
Date Fri, 13 Jan 2017 08:34:39 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/131#discussion_r95954841
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/javaapi/functions/FlatMapFunction.scala
---
    @@ -15,17 +15,18 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    +package org.apache.gearpump.streaming.dsl.javaapi.functions
     
    -package org.apache.gearpump.streaming.javaapi.dsl.functions;
    -
    -import java.io.Serializable;
    +import org.apache.gearpump.streaming.dsl.scalaapi.functions.SerializableFunction
     
     /**
    - * GroupBy function which assign value of type T to groups
    + * Transforms one input into zero or more outputs of possibly different types.
    + * This Java version of FlatMapFunction returns a java.util.Iterator.
      *
    - * @param <T> Input value type
    - * @param <Group> Group Type
    + * @param T Input value type
    + * @param R Output value type
      */
    -public interface GroupByFunction<T, Group> extends Serializable {
    -  Group apply(T t);
    +abstract class FlatMapFunction[T, R] extends SerializableFunction {
    --- End diff --
    
    Do you think just call it JFlatMapFunction will be less confusing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message