gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #126: Gearpump 257 remote application submit...
Date Wed, 28 Dec 2016 13:22:06 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/126#discussion_r94031976
  
    --- Diff: core/src/main/scala/org/apache/gearpump/jarstore/FileServer.scala ---
    @@ -145,8 +145,7 @@ object FileServer {
         }
     
         private def entity(file: File)(implicit ec: ExecutionContext): Future[RequestEntity]
= {
    -      val entity = HttpEntity(MediaTypes.`application/octet-stream`, file.length(),
    -        FileIO.fromFile(file, chunkSize = 100000))
    +      val entity = HttpEntity(MediaTypes.`application/octet-stream`, file, chunkSize
= 100000)
    --- End diff --
    
    That looks valid but could you put it in a separate PR ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message