Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
Date: Tue, 6 Sep 2016 12:41:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@gearpump.incubator.apache.org
Message-ID: <JIRA.13002884.1473159797000.497141.1473165680558@Atlassian.JIRA>
In-Reply-To: <JIRA.13002884.1473159797000@Atlassian.JIRA>
References: <JIRA.13002884.1473159797000@Atlassian.JIRA> <JIRA.13002884.1473159797048@arcas>
Subject: [jira] [Commented] (GEARPUMP-205) remove hdfs dependency from
 command gear's classpath
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Sep 2016 12:41:53 -0000


    [ https://issues.apache.org/jira/browse/GEARPUMP-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467315#comment-15467315 ] 

ASF GitHub Bot commented on GEARPUMP-205:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/81#discussion_r77625961
  
    --- Diff: core/src/main/scala/org/apache/gearpump/jarstore/JarStoreService.scala ---
    @@ -15,72 +15,39 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -
     package org.apache.gearpump.jarstore
     
    -import java.io.File
    -import java.net.URI
    -import java.util.ServiceLoader
    -import scala.collection.JavaConverters._
    -
    -import akka.actor.ActorSystem
    -import com.typesafe.config.Config
    -
    -import org.apache.gearpump.util.{Constants, Util}
    -
    -case class FilePath(path: String)
    -
    -/**
    - * JarStoreService is used to manage the upload/download of binary files,
    - * like user submitted application jar.
    - */
    -trait JarStoreService {
    -  /**
    -   * The scheme of the JarStoreService.
    -   * Like "hdfs" for HDFS file system, and "file" for a local
    -   * file system.
    -   */
    -  val scheme: String
    -
    -  /**
    -   * Init the Jar Store.
    -   */
    -  def init(config: Config, system: ActorSystem)
    -
    -  /**
    -   * This function will copy the local file to the remote JarStore, called from client side.
    -   * @param localFile The local file
    -   */
    -  def copyFromLocal(localFile: File): FilePath
    -
    -  /**
    -   * This function will copy the remote file to local file system, called from client side.
    -   *
    -   * @param localFile The destination of file path
    -   * @param remotePath The remote file path from JarStore
    -   */
    -  def copyToLocalFile(localFile: File, remotePath: FilePath)
    -}
    -
    -object JarStoreService {
    -
    -  /**
    -   * Get a active JarStoreService by specifying a scheme.
    -   *
    -   * Please see config [[org.apache.gearpump.util.Constants#GEARPUMP_APP_JAR_STORE_ROOT_PATH]] for
    -   * more information.
    -   */
    -  def get(config: Config): JarStoreService = {
    -    val jarStoreRootPath = config.getString(Constants.GEARPUMP_APP_JAR_STORE_ROOT_PATH)
    -    get(jarStoreRootPath)
    +import akka.actor.{Actor, Stash}
    +import akka.pattern.pipe
    +import org.slf4j.Logger
    +
    +import org.apache.gearpump.cluster.ClientToMaster.{GetJarStoreServer, JarStoreServerAddress}
    +import org.apache.gearpump.util._
    +
    +class JarStoreService(jarStoreRootPath: String) extends Actor with Stash {
    --- End diff --
    
    Do you think `JarStoreServer` is better mapping to `JarStoreClient` ?


> remove hdfs dependency from command gear's classpath
> ----------------------------------------------------
>
>                 Key: GEARPUMP-205
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-205
>             Project: Apache Gearpump
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.2
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)