Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-85-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-85-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request #85: [GEARPUMP-23] add window dsl
Content-Type: text/plain
Message-Id: <20160927222022.8E947DFD9F@git1-us-west.apache.org>
Date: Tue, 27 Sep 2016 22:20:22 +0000 (UTC)
archived-at: Wed, 28 Sep 2016 01:15:15 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/85#discussion_r80808708
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/Stream.scala ---
    @@ -115,20 +121,17 @@ class Stream[T](
        *
        * For example,
        * {{{
    -   * Stream[People].groupBy(_.gender).flatmap(..).filter.(..).reduce(..)
    +   * Stream[People].groupBy(_.gender).flatMap(..).filter(..).reduce(..)
        * }}}
        *
    -   * @param fun  Group by function
    +   * @param fn  Group by function
        * @param parallelism  Parallelism level
        * @param description  The description
        * @return  the grouped stream
        */
    -  def groupBy[Group](fun: T => Group, parallelism: Int = 1, description: String = null)
    -    : Stream[T] = {
    -    val groupOp = GroupByOp(fun, parallelism, Option(description).getOrElse("groupBy"))
    -    graph.addVertex(groupOp)
    -    graph.addEdge(thisNode, edge.getOrElse(Shuffle), groupOp)
    -    new Stream[T](graph, groupOp)
    +  def groupBy[GROUP](fn: T => GROUP, parallelism: Int = 1, description: String = "groupBy")
    +    : GroupByStream[T, GROUP] = {
    +    groupByWindow(DefaultGroupBy(fn), parallelism, description)
    --- End diff --
    
    Yes, I have a new version that does so. Will update today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---