Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A4944200B88 for ; Thu, 22 Sep 2016 17:50:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A3239160AAD; Thu, 22 Sep 2016 15:50:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D9380160AA9 for ; Thu, 22 Sep 2016 17:50:01 +0200 (CEST) Received: (qmail 64454 invoked by uid 500); 22 Sep 2016 15:50:01 -0000 Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gearpump.incubator.apache.org Delivered-To: mailing list dev@gearpump.incubator.apache.org Delivered-To: moderator for dev@gearpump.incubator.apache.org Received: (qmail 4264 invoked by uid 99); 22 Sep 2016 10:59:18 -0000 X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled From: manuzhang To: dev@gearpump.incubator.apache.org Reply-To: dev@gearpump.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-gearpump pull request #86: [GEARPUMP-204]add unit test for externa... Content-Type: text/plain Message-Id: <20160922105915.C9A2CE03CE@git1-us-west.apache.org> Date: Thu, 22 Sep 2016 10:59:15 +0000 (UTC) archived-at: Thu, 22 Sep 2016 15:50:02 -0000 Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/86#discussion_r80017412 --- Diff: external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala --- @@ -97,7 +101,7 @@ class HBaseSink( } /** - * Overrides Java's default deserialization + * Overrides Java's default serialization --- End diff -- serialization ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---