Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 08129200B88 for ; Thu, 22 Sep 2016 17:47:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 06CA2160AAD; Thu, 22 Sep 2016 15:47:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 460D0160AA9 for ; Thu, 22 Sep 2016 17:47:15 +0200 (CEST) Received: (qmail 53201 invoked by uid 500); 22 Sep 2016 15:47:14 -0000 Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gearpump.incubator.apache.org Delivered-To: mailing list dev@gearpump.incubator.apache.org Delivered-To: moderator for dev@gearpump.incubator.apache.org Received: (qmail 73096 invoked by uid 99); 22 Sep 2016 05:54:36 -0000 X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled From: Roshanson To: dev@gearpump.incubator.apache.org Reply-To: dev@gearpump.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-gearpump pull request #86: [GEARPUMP-204]add unit test for externa... Content-Type: text/plain Message-Id: <20160922055432.6425DE02DA@git1-us-west.apache.org> Date: Thu, 22 Sep 2016 05:54:32 +0000 (UTC) archived-at: Thu, 22 Sep 2016 15:47:16 -0000 Github user Roshanson commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/86#discussion_r79978998 --- Diff: external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala --- @@ -19,39 +19,47 @@ package org.apache.gearpump.external.hbase import java.io.{File, ObjectInputStream, ObjectOutputStream} +import org.apache.gearpump.Message +import org.apache.gearpump.cluster.UserConfig +import org.apache.gearpump.streaming.sink.DataSink +import org.apache.gearpump.streaming.task.TaskContext +import org.apache.gearpump.util.{Constants, FileUtils} import org.apache.hadoop.conf.Configuration import org.apache.hadoop.hbase.client.{Connection, ConnectionFactory, Put} +import org.apache.hadoop.hbase.security.UserProvider import org.apache.hadoop.hbase.util.Bytes import org.apache.hadoop.hbase.{HBaseConfiguration, TableName} -import org.apache.hadoop.hbase.security.{User, UserProvider} import org.apache.hadoop.security.UserGroupInformation -import org.apache.gearpump.Message -import org.apache.gearpump.cluster.UserConfig -import org.apache.gearpump.streaming.sink.DataSink -import org.apache.gearpump.streaming.task.TaskContext -import org.apache.gearpump.util.{Constants, FileUtils} +class HBaseSink(userconfig: UserConfig, tableName: String, @transient var connection: Connection, + @transient var configuration: Configuration) + extends DataSink { -class HBaseSink( - userconfig: UserConfig, tableName: String, @transient var configuration: Configuration) - extends DataSink{ - lazy val connection = HBaseSink.getConnection(userconfig, configuration) + + // var connection = HBaseSink.getConnection(userconfig, configuration) --- End diff -- I use the parameter of 'connection' to separate real connection to HBase testing and unit testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---