gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkasravi <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #77: [GEARPUMP-197] fix busy loop in FetchTh...
Date Sun, 28 Aug 2016 15:53:13 GMT
Github user kkasravi commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/77#discussion_r76534338
  
    --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/consumer/FetchThread.scala
---
    @@ -133,19 +133,21 @@ private[kafka] class FetchThread(
     
       /**
        * fetch message from each TopicAndPartition in a round-robin way
    +   *
    +   * @return whether to fetch more messages
    --- End diff --
    
    akka-streams has this GraphStage called InterLeave where upstreams are cycled and N messages
are pulled from each one. I'm wondering if we should expose a policy related to fetch messages
which is now round-robin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message