gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...
Date Mon, 22 Aug 2016 02:56:30 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/67#discussion_r75612765
  
    --- Diff: examples/streaming/fsio/src/main/scala/org/apache/gearpump/streaming/examples/fsio/SeqFileStreamProducer.scala
---
    @@ -64,6 +65,6 @@ class SeqFileStreamProducer(taskContext: TaskContext, config: UserConfig)
     object SeqFileStreamProducer {
       def INPUT_PATH: String = "inputpath"
     
    -  val Start = Message("start")
    -  val Continue = Message("continue")
    +  val Start = Watermark(Instant.now)
    +  val Continue = Watermark(Instant.now)
    --- End diff --
    
    This Continue's timestamp will never move forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message