gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #67: fix GEARPUMP-32, introduce source water...
Date Wed, 27 Jul 2016 10:09:50 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/67#discussion_r72413816
  
    --- Diff: external/kafka/src/main/scala/org/apache/gearpump/streaming/kafka/lib/source/AbstractKafkaSource.scala
---
    @@ -92,6 +91,7 @@ abstract class AbstractKafkaSource(
     
         LOG.info("KafkaSource opened at start time {}", startTime)
         this.startTime = startTime
    --- End diff --
    
    Is startTime still needed if change `maybeRecover()` to `maybeRecover(startTime)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message