Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
From: manuzhang <git@git.apache.org>
To: dev@gearpump.incubator.apache.org
Reply-To: dev@gearpump.incubator.apache.org
References: <git-pr-11-incubator-gearpump@git.apache.org>
In-Reply-To: <git-pr-11-incubator-gearpump@git.apache.org>
Subject: [GitHub] incubator-gearpump pull request: fix #106 Gearpump Redis Integration
Content-Type: text/plain
Message-Id: <20160601081628.DD0EBE0498@git1-us-west.apache.org>
Date: Wed,  1 Jun 2016 08:16:28 +0000 (UTC)
archived-at: Wed, 01 Jun 2016 13:13:46 -0000

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/11#discussion_r65319134
  
    --- Diff: experiments/redis/src/main/scala/org/apache/gearpump/streaming/redis/RedisStorage.scala ---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.gearpump.streaming.redis
    +
    +import io.gearpump.google.common.base.Strings
    +import org.apache.gearpump.Message
    +import org.apache.gearpump.streaming.redis.RedisMessage._
    +import org.apache.gearpump.streaming.sink.DataSink
    +import org.apache.gearpump.streaming.task.TaskContext
    +import org.apache.gearpump.util.LogUtil
    +import redis.clients.jedis.Jedis
    +import redis.clients.jedis.Protocol.{DEFAULT_DATABASE, DEFAULT_HOST, DEFAULT_PORT, DEFAULT_TIMEOUT}
    +
    +class RedisStorage(
    --- End diff --
    
    How is `RedisStorage` intended to be used as a `DataSink` ? As I understand it, a storage supports both read and write functions while this class only supports write. How about extending the `CheckpointStore` interface ?  How is Redis typically used in a streaming engine ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---