gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: fix GEARPUMP-83, show application pending o...
Date Wed, 01 Jun 2016 03:16:11 GMT
GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/31

    fix GEARPUMP-83, show application pending on worker down

    Changes include:
    
    1. add `activeAppMasters` set to `masterState` and `deadAppMasters` is changed to set
of appIds. Now all existent applications will be in `appMasterRegistry` and in **pending**
status by default. Those in `activeAppMasters` will have **active** status and `deadAppMasters`
**inactive** status.
    2. add a status column to the "apps" page on the dashboard. status will be one of pending,
active and inactive. 
    3. Internally, `TaskManager` will send an `ApplicationReady` message to `AppMaster` on
ApplicationReady state(with DAG version larger than -1). In turn, `AppMaster` will send an
`ActivateApplication(appId)` message to `Master`(forwarded to `AppManager`). Then the `appId`
is added to `activeAppMasters`. It is removed from `activeAppMasters` either when an application
is killed or recovered. 
    4. add UTs and fix a bunch of warnings (typos, suspicious shadowing, etc)
    
    The snapshot of "apps" page with active and inactive applications
    
    ![snip20160601_3](https://cloud.githubusercontent.com/assets/1191767/15697157/25860834-27ea-11e6-8363-46d31543d924.png)
    
    
    The snapshot of "apps" page when all workers down
    
    ![snip20160601_4](https://cloud.githubusercontent.com/assets/1191767/15697159/2b45aea0-27ea-11e6-87f2-f67d02fce6ea.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump appmaster_status

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 9529796fc319f1ed69cc6cf726d8f1afef47ef1b
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2016-05-31T07:47:09Z

    fix GEARPUMP-83, show application pending on worker down

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message