gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-83) After killing all worker instances, application status should not be described as active
Date Wed, 01 Jun 2016 03:16:12 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309167#comment-15309167
] 

ASF GitHub Bot commented on GEARPUMP-83:
----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/31

    fix GEARPUMP-83, show application pending on worker down

    Changes include:
    
    1. add `activeAppMasters` set to `masterState` and `deadAppMasters` is changed to set
of appIds. Now all existent applications will be in `appMasterRegistry` and in **pending**
status by default. Those in `activeAppMasters` will have **active** status and `deadAppMasters`
**inactive** status.
    2. add a status column to the "apps" page on the dashboard. status will be one of pending,
active and inactive. 
    3. Internally, `TaskManager` will send an `ApplicationReady` message to `AppMaster` on
ApplicationReady state(with DAG version larger than -1). In turn, `AppMaster` will send an
`ActivateApplication(appId)` message to `Master`(forwarded to `AppManager`). Then the `appId`
is added to `activeAppMasters`. It is removed from `activeAppMasters` either when an application
is killed or recovered. 
    4. add UTs and fix a bunch of warnings (typos, suspicious shadowing, etc)
    
    The snapshot of "apps" page with active and inactive applications
    
    ![snip20160601_3](https://cloud.githubusercontent.com/assets/1191767/15697157/25860834-27ea-11e6-8363-46d31543d924.png)
    
    
    The snapshot of "apps" page when all workers down
    
    ![snip20160601_4](https://cloud.githubusercontent.com/assets/1191767/15697159/2b45aea0-27ea-11e6-87f2-f67d02fce6ea.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump appmaster_status

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 9529796fc319f1ed69cc6cf726d8f1afef47ef1b
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2016-05-31T07:47:09Z

    fix GEARPUMP-83, show application pending on worker down

----


> After killing all worker instances, application status should not be described as active
> ----------------------------------------------------------------------------------------
>
>                 Key: GEARPUMP-83
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-83
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: Dashboard
>    Affects Versions: 0.8.0
>            Reporter: Kam Kasravi
>            Assignee: Manu Zhang
>            Priority: Minor
>             Fix For: 0.8.1
>
>
> Step to reproduce:
> Start cluster with one worker
> Start a word count
> Kill the worker
> Expect /api/v1.0/master/applist actually returns app status as active, but application's
detail page is not available. I think as there is no resource to run the application, the
application is in some abnormal status. In order not to mislead user, I think we should invent
a new status, might be recovering or something.
> Example output:
> {code}
> {"appMasters":[{"status":"active","appId":1,"appName":"dag","appMasterPath":"akka.tcp://app1-executor-1@127.0.0.1:46761/user/daemon/appdaemon1/$c","workerPath":"akka.tcp://48a47aa6-81c0-493c-9948-9d7d4c946db6@127.0.0.1:59201/user/Worker48a47aa6-81c0-493c-9948-9d7d4c946db6","submissionTime":"1451894551477","startTime":"1451894553568","user":"qxu"},{"status":"active","appId":2,"appName":"wordCount","appMasterPath":"akka.tcp://app2-executor-1@127.0.0.1:49261/user/daemon/appdaemon2/$c","workerPath":"akka.tcp://48a47aa6-81c0-493c-9948-9d7d4c946db6@127.0.0.1:59201/user/Worker48a47aa6-81c0-493c-9948-9d7d4c946db6","submissionTime":"1451898038991","startTime":"1451898040265","user":"qxu"}]}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message