gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-32) Minimum clock of source Tasks maybe inaccurate
Date Fri, 03 Jun 2016 08:02:59 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313810#comment-15313810
] 

ASF GitHub Bot commented on GEARPUMP-32:
----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/33
  
    ## [Current coverage][cc-pull] is **65.96%**
    > Merging [#33][cc-pull] into [master][cc-base-branch] will increase coverage by **2.45%**
    
    1. 5 files (not in diff) in `...rpump/streaming/task` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F7461736B)
    1. 2 files (not in diff) in `...streaming/state/impl` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F73746174652F696D706C)
    1. 2 files (not in diff) in `.../streaming/state/api` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F73746174652F617069)
    1. 2 files (not in diff) in `...mp/streaming/metrics` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6D657472696373)
    1. 2 files (not in diff) in `...p/streaming/executor` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6578656375746F72)

      - Misses `-1` 
      - Hits `+1`
    1. 2 files (not in diff) in `...p/streaming/dsl/plan` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F64736C2F706C616E)
    1. 1 files (not in diff) in `...arpump/streaming/dsl` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F64736C)
    1. 3 files (not in diff) in `.../streaming/appmaster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6170706D6173746572)
    1. 1 files (not in diff) in `...e/gearpump/streaming` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E67)
    1. 2 files (not in diff) in `.../lib/source/consumer` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#65787465726E616C2F6B61666B612F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6B61666B612F6C69622F736F757263652F636F6E73756D6572)
    
    ```diff
    @@             master        #33   diff @@
    ==========================================
      Files           178        178          
      Lines          5922       5929     +7   
      Methods        5644       5631    -13   
      Messages          0          0          
      Branches        278        298    +20   
    ==========================================
    + Hits           3761       3911   +150   
    + Misses         2161       2018   -143   
      Partials          0          0          
    ```
    
    [![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/33/graphs/sunburst.svg?src=pr&size=150)][cc-pull]
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ec04cf7...d88f667][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/ec04cf7666020ba15764611ac872344549f5200c...d88f6675bdf49f2a302dddfb5a05a00de3601531
    [cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/33?src=pr


> Minimum clock of source Tasks maybe inaccurate
> ----------------------------------------------
>
>                 Key: GEARPUMP-32
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-32
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: streaming
>    Affects Versions: 0.8.0
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>             Fix For: 0.8.1
>
>
> Moved from [https://github.com/gearpump/gearpump/issues/1835] and reported by [Zhu Yueqian|https://github.com/yueqianzhu]
> {quote}
> Source tasks have not any upstreamClocks. So, startClock is the minimum of pending clocks
when recover happen.
> eg below:
> source task1: timeStamp:15,not ACK, minClockValue maybe is 15(<= 15).
> source task2: timeStamp:10,ACKed, minClockValue maybe is Long.MaxValue
> when recover happen,startClock maybe is 15. where is the data between 10 to 15 at task2?
> {quote}
> More context on this issue:
> In Gearpump, we maintain a global minimum clock tracked from a message's timestamp across
all tasks. It means messages with timestamp before this clock have all been processed. An
application will restart from this value on failure, and thus at-least-once message delivery
could be guaranteed. 
> The global minimum clock is the lower bound of all the Tasks' minimum clocks. 
> For a task, the minimum clock is the lower of 
> # upstream minimum clock
> # a. the minimum timestamp of unacked messages
>    b. Long.MaxValue if all messages have been acked.
>  
> Note that 2.b allows the global minimum clock to progress and it is almost safe since
the clock is also bounded by the upstream minimum clock. I said "almost safe" because a source
task has no upstream but we assume the upstream minimum clock is Long.MaxValue. Thus, the
scenario described by Zhu Yueqian could happen and breaks at-least-once guarantee. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message