gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #34: fix GEARPUMP-153, throw exception on ma...
Date Fri, 03 Jun 2016 08:27:24 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/34#discussion_r65672571
  
    --- Diff: daemon/src/main/scala/org/apache/gearpump/cluster/main/AppSubmitter.scala ---
    @@ -95,7 +94,8 @@ object AppSubmitter extends AkkaApp with ArgumentsParser {
         val mainInManifest = Option(new JarFile(jar).getManifest.getMainAttributes.
           getValue("Main-Class")).getOrElse("")
     
    -    if (remainArgs.length > 0 && Try(classLoader.loadClass(remainArgs(0))).isSuccess)
{
    +    if (remainArgs.length > 0) {
    --- End diff --
    
    What if I submit wordcount without the mainclass but specify other arguments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message