Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC745200AF7 for ; Mon, 30 May 2016 16:25:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CB054160969; Mon, 30 May 2016 14:25:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 22ADB160A19 for ; Mon, 30 May 2016 16:25:17 +0200 (CEST) Received: (qmail 68546 invoked by uid 500); 30 May 2016 14:25:17 -0000 Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gearpump.incubator.apache.org Delivered-To: mailing list dev@gearpump.incubator.apache.org Received: (qmail 68522 invoked by uid 99); 30 May 2016 14:25:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 May 2016 14:25:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DB1DA1A47E4 for ; Mon, 30 May 2016 14:25:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5rILKmp6vJ_8 for ; Mon, 30 May 2016 14:25:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id E903960D1F for ; Mon, 30 May 2016 14:25:13 +0000 (UTC) Received: (qmail 68514 invoked by uid 99); 30 May 2016 14:25:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 May 2016 14:25:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F17522C1F5C for ; Mon, 30 May 2016 14:25:12 +0000 (UTC) Date: Mon, 30 May 2016 14:25:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@gearpump.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEARPUMP-141) Remove useless method MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 30 May 2016 14:25:19 -0000 [ https://issues.apache.org/jira/browse/GEARPUMP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306705#comment-15306705 ] ASF GitHub Bot commented on GEARPUMP-141: ----------------------------------------- Github user darionyaphet commented on the pull request: https://github.com/apache/incubator-gearpump/pull/20#issuecomment-222503486 @huafengw @manuzhang Could add some comment about this functions ? This functions is very confuse to others . > Remove useless method > --------------------- > > Key: GEARPUMP-141 > URL: https://issues.apache.org/jira/browse/GEARPUMP-141 > Project: Apache Gearpump > Issue Type: Improvement > Components: hbase > Affects Versions: 0.8.0 > Reporter: darion yaphet > Priority: Minor > > In external-hbase module , writeObject and readObject seems never used . We can remove this methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)