gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-143) Document `worker.executor-share-same-jvm-as-worker` config parameter
Date Sun, 29 May 2016 13:49:12 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305908#comment-15305908
] 

ASF GitHub Bot commented on GEARPUMP-143:
-----------------------------------------

Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/29#discussion_r65005272
  
    --- Diff: docs/deployment-configuration.md ---
    @@ -89,3 +89,4 @@ This is the default configuration for `gear.conf`.
     | gearpump.shared-thread-pool-dispatcher | default Dispatcher with "fork-join-executor"
| default shared thread pool dispatcher |
     | gearpump.single-thread-dispatcher | PinnedDispatcher | default single thread dispatcher
|
     | gearpump.serialization-framework | "org.apache.gearpump.serializer.FastKryoSerializationFramework"
| Gearpump has built-in serialization framework using Kryo. Users are allowed to use a different
serialization framework, like Protobuf. See `org.apache.gearpump.serializer.FastKryoSerializationFramework`
to find how a custom serialization framework can be defined |
    +| worker.executor-share-same-jvm-as-worker | false | whether the executor actor is started
in a seperate jvm(process) from which running the worker actor |
    --- End diff --
    
    small typo "seperate".  IMHO,  "whether ... is started in the same JVM(process)" is more
intuitive since the configuration is "share-same-jvm". 


> Document `worker.executor-share-same-jvm-as-worker` config parameter
> --------------------------------------------------------------------
>
>                 Key: GEARPUMP-143
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-143
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: doc
>            Reporter: Karol Brejna
>
> Default gear.conf holds the following key/value pair:
> {{worker.executor-share-same-jvm-as-worker = false}}
> There is no description of the "behaviour" of this setting (how to use it, what are the
consequences).
> (http://gearpump.apache.org/releases/latest/deployment-configuration.html)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message