gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: fix GEARPUMP-143 add doc worker.e...
Date Sun, 29 May 2016 13:49:11 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/29#discussion_r65005272
  
    --- Diff: docs/deployment-configuration.md ---
    @@ -89,3 +89,4 @@ This is the default configuration for `gear.conf`.
     | gearpump.shared-thread-pool-dispatcher | default Dispatcher with "fork-join-executor"
| default shared thread pool dispatcher |
     | gearpump.single-thread-dispatcher | PinnedDispatcher | default single thread dispatcher
|
     | gearpump.serialization-framework | "org.apache.gearpump.serializer.FastKryoSerializationFramework"
| Gearpump has built-in serialization framework using Kryo. Users are allowed to use a different
serialization framework, like Protobuf. See `org.apache.gearpump.serializer.FastKryoSerializationFramework`
to find how a custom serialization framework can be defined |
    +| worker.executor-share-same-jvm-as-worker | false | whether the executor actor is started
in a seperate jvm(process) from which running the worker actor |
    --- End diff --
    
    small typo "seperate".  IMHO,  "whether ... is started in the same JVM(process)" is more
intuitive since the configuration is "share-same-jvm". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message