gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: fix #106 Gearpump Redis Integrati...
Date Thu, 19 May 2016 02:39:29 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/11#discussion_r63815402
  
    --- Diff: project/BuildExample.scala ---
    @@ -229,4 +229,20 @@ object BuildExample extends sbt.Build {
             CrossVersion.binaryScalaVersion(scalaVersion.value)
         )
       ) dependsOn (streaming % "test->test; provided")
    +
    +  lazy val examples_redis = Project(
    +    id = "gearpump-examples-redis",
    +    base = file("examples/streaming/redis"),
    +    settings = commonSettings ++ noPublish ++ myAssemblySettings ++
    +      Seq(
    +        mainClass in (Compile, packageBin) := Some("org.apache.gearpump.streaming.example.redis.RedisSourceSinkExample"),
    +        target in assembly := baseDirectory.value.getParentFile.getParentFile / "target"
/
    +          CrossVersion.binaryScalaVersion(scalaVersion.value)
    +      ) ++
    +      Seq(
    +        mainClass in (Compile, packageBin) := Some("org.apache.gearpump.streaming.example.redis.RedisSourceStorageExample"),
    --- End diff --
    
    That's not correct, one manifest can only have one main class. 
    ```
    Seq(
             mainClass in (Compile, packageBin) := Some("org.apache.gearpump.streaming.example.redis.RedisSourceSinkExample"),
             target in assembly := baseDirectory.value.getParentFile.getParentFile / "target"
/
               CrossVersion.binaryScalaVersion(scalaVersion.value)
           )
    ``` is enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message