Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
Date: Wed, 27 Apr 2016 02:49:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@gearpump.incubator.apache.org
Message-ID: <JIRA.12960195.1461117683000.42421.1461725352923@Atlassian.JIRA>
In-Reply-To: <JIRA.12960195.1461117683000@Atlassian.JIRA>
References: <JIRA.12960195.1461117683000@Atlassian.JIRA>
 <JIRA.12960195.1461117683253@arcas>
Subject: [jira] [Commented] (GEARPUMP-41) property
 akka.scheduler.tick-duration will be override and potentially go wrong on
 Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GEARPUMP-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259442#comment-15259442 ] 

ASF GitHub Bot commented on GEARPUMP-41:
----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/4#discussion_r61196854
  
    --- Diff: daemon/src/main/scala/io/gearpump/cluster/worker/Worker.scala ---
    @@ -361,12 +363,19 @@ private[cluster] object Worker {
             // Falls back to workerConfig
             .withFallback(workerConfig)
     
    +      // Minimum supported akka.scheduler.tick-duration on Windows is 10ms
    +      val duration = config.getInt(Constants.AKKA_SCHEDULER_TICK_DURATION)
    +      val updatedConf = if (akka.util.Helpers.isWindows && duration < 10) {
    +        LOG.warn(s"akka.scheduler.tick-duration on Windows must be larger than 10ms, set to 10ms")
    +        config.withValue(Constants.AKKA_SCHEDULER_TICK_DURATION, ConfigValueFactory.fromAnyRef(10))
    +      } else {
    --- End diff --
    
    But -1 is less than 10


> property akka.scheduler.tick-duration will be override and potentially go wrong on Windows
> ------------------------------------------------------------------------------------------
>
>                 Key: GEARPUMP-41
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-41
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: daemon
>    Affects Versions: 0.8.0
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>         Attachments: GEARPUMP-41.patch
>
>
> How to reproduce:
> 1. Launch Master and Dashboard on a Linux machine.
> 2. Launch a Worker on a Windows machine.
> 3. Submit an application from dashboard.
> Then the application will fail to launch Executor on Windows because the property akka.scheduler.tick-duration is override by the value from Linux Machine, which by default is 1.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)