Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
Date: Tue, 5 Apr 2016 03:09:25 +0000 (UTC)
From: "Weihua Jiang (JIRA)" <jira@apache.org>
To: dev@gearpump.incubator.apache.org
Message-ID: <JIRA.12955758.1459776370000.134249.1459825765460@Atlassian.JIRA>
In-Reply-To: <JIRA.12955758.1459776370000@Atlassian.JIRA>
References: <JIRA.12955758.1459776370000@Atlassian.JIRA>
 <JIRA.12955758.1459776370048@arcas>
Subject: [jira] [Commented] (GEARPUMP-10) Downgrade netty from Netty 4 to
 Netty 3.8 cause the OAuth2 authentication failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GEARPUMP-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225576#comment-15225576 ] 

Weihua Jiang commented on GEARPUMP-10:
--------------------------------------

+1.

> Downgrade netty from Netty 4 to Netty 3.8 cause the OAuth2 authentication failure
> ---------------------------------------------------------------------------------
>
>                 Key: GEARPUMP-10
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-10
>             Project: Apache Gearpump
>          Issue Type: Bug
>            Reporter: Sean Zhong
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> *Problem:*
> In Gearpump, Ning is used by a OAuth2 authentication library. Ning 1.9.33 requires netty 3.10.
> When downgrading netty from 4 to 3.8 in PR https://github.com/gearpump/gearpump/pull/2017, it report error like this
> {quote}
> 2016-04-04 21:14:29,407 INFO SecurityService@AUDIT: Failed to login user from 127.0.0.1:54062
> java.util.concurrent.ExecutionException: Boxed Error
>         at scala.concurrent.impl.Promise$.resolver(Promise.scala:55)
>         at scala.concurrent.impl.Promise$.scala$concurrent$impl$Promise$$resolveTry(Promise.scala:47)
>         at scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:244)
>         at scala.concurrent.Promise$class.complete(Promise.scala:55)
>         at scala.concurrent.impl.Promise$DefaultPromise.complete(Promise.scala:153)
>         at scala.concurrent.impl.Promise$DefaultPromise.failure(Promise.scala:153)
>         at io.gearpump.services.security.oauth2.impl.BaseOAuth2Authenticator$$anon$3.onThrowable(BaseOAuth2Authenticator.scala:149)
>         at com.github.scribejava.core.model.OAuthRequestAsync$OAuthAsyncCompletionHandler.onThrowable(OAuthRequestAsync.java:114)
>         at com.ning.http.client.providers.netty.future.NettyResponseFuture.abort(NettyResponseFuture.java:238)
>         at com.ning.http.client.providers.netty.request.NettyRequestSender.abort(NettyRequestSender.java:422)
>         at com.ning.http.client.providers.netty.handler.HttpProtocol.exitAfterHandlingConnect(HttpProtocol.java:358)
>         at com.ning.http.client.providers.netty.handler.HttpProtocol.handleHttpResponse(HttpProtocol.java:428)
>         at com.ning.http.client.providers.netty.handler.HttpProtocol.handle(HttpProtocol.java:470)
>         at com.ning.http.client.providers.netty.handler.Processor.messageReceived(Processor.java:88)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>         at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
>         at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:142)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>         at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
>         at org.jboss.netty.handler.codec.http.HttpContentDecoder.messageReceived(HttpContentDecoder.java:108)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>         at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
>         at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
>         at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:459)
>         at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:536)
>         at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:435)
>         at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
>         at org.jboss.netty.handler.codec.http.HttpClientCodec.handleUpstream(HttpClientCodec.java:92)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
>         at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
>         at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
>         at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
>         at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
>         at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)
>         at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:318)
>         at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
>         at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
>         at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
>         at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: org.jboss.netty.handler.ssl.SslHandler.<init>(Ljavax/net/ssl/SSLEngine;Lorg/jboss/netty/handler/ssl/SslBufferPool;ZLorg/jboss/netty/util/Timer;J)V
>         at com.ning.http.client.providers.netty.channel.ChannelManager.createSslHandler(ChannelManager.java:402)
>         at com.ning.http.client.providers.netty.channel.ChannelManager.upgradeProtocol(ChannelManager.java:426)
>         at com.ning.http.client.providers.netty.handler.HttpProtocol.exitAfterHandlingConnect(HttpProtocol.java:355)
>         ... 33 more
> {quote}
> *Suggestion*:
> Since we keep netty3.8 basically for performance reason, so we should ONLY use netty 3.10 only for UI service, while all other part (including streaming, and daemon) still using netty3.8.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)