Mailing-List: contact dev-help@gearpump.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gearpump.incubator.apache.org
Date: Wed, 13 Apr 2016 14:45:21 +0000 (UTC)
From: Kam Kasravi <kamkasravi@gmail.com>
Reply-To: Kam Kasravi <kamkasravi@gmail.com>
To: "dev@gearpump.incubator.apache.org" <dev@gearpump.incubator.apache.org>
Message-ID: <162528658.2490592.1460558721669.JavaMail.yahoo@mail.yahoo.com>
In-Reply-To: <BLU180-W85FD9783AE752CBE0FEEAA8960@phx.gbl>
References: 
 <CADiMvzXWDvTtvH+H4uiEtzQa-BEh2P7Gm6uqQHaabkqsMg0oBw@mail.gmail.com>
 <2105443893.2441939.1460557610940.JavaMail.yahoo@mail.yahoo.com>
 <BLU180-W85FD9783AE752CBE0FEEAA8960@phx.gbl>
Subject: Re: DISCUSS: Review, and decide whether to accept additional code
 commit from github.com/gearpump
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_2490591_1886292194.1460558721661"

------=_Part_2490591_1886292194.1460558721661
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

+1 on skipping the review process per Weihua's comment above.=20

    On Wednesday, April 13, 2016 7:39 AM, JiangWeihua <whjiang@outlook.com>=
 wrote:
=20

 I will prefer to skip the review process for these commits as they have al=
ready been reviewed and we need to have a stable base to work on asap. And =
Sean's recent style fix impacts hundreds of files.=20

> Date: Wed, 13 Apr 2016 14:26:50 +0000
> From: kamkasravi@gmail.com
> To: dev@gearpump.incubator.apache.org
> Subject: Re: DISCUSS: Review, and decide whether to accept additional cod=
e commit from github.com/gearpump
>=20
> If we have matching JIRA's I would prefer to import per JIRA and close th=
e JIRA.This makes it consistent with the apache process.=20
> ThanksKam=20
>=20
>=C2=A0 =C2=A0 On Tuesday, April 12, 2016 9:17 PM, Sean Zhong <clockfly@gma=
il.com> wrote:
>=C2=A0=20
>=20
>=C2=A0 *Reason:*
> During the waiting of initial code import to Apache, there are 19 PR
> committed in old git repo github.com/gearpump.
>=20
> In this thread, we should DISCUSS whether we should import these 19 PR to
> Apache git, which is
> https://git-wip-us.apache.org/repos/asf/incubator-gearpump.git.
>=20
> We'd like to invite you to review the FAQ and PR list, to raise any
> concerns if it exists.
>=20
> The discussion will open for 72 hours, after the discussion, a VOTE threa=
d
> will be called for the importing.
>=20
> *FAQ:*
> 1. How long the transition happens?
> We waited for about 28 days. The code commit happens in these past 28 day=
s.
>=20
> 2. How many PR are we talking about?
> There are 17 PR covered. Start sha1: d5343681edde427022bf4c225ce602
> 2a6904ae88, End sha1: 79e15668c6498a54da691626dd2f91bf205d3720
>=20
> 3. Whether they is important fix?
> Yes, they fix many bugs and improve the features.
>=20
> 4. Whether these PR have reviews and +1 from initial Apache committers?
> Yes, all these PRs have reviews and at least one +1 from Apache initial
> committers.
>=20
> 5. Whether these code has good code style by Apache process?
> Yes. Github.com/gearpump also have code style requirement, which is
> consistent with Apache basic requirements.
>=20
> 6. Whether The ICLA are fired for the contributors of these PR?
> Yes. All these 17 PR comes from Intel employees, the licensing is covered
> by CCLA. The contributors list: Manu, Stanley Xu, Sean Zhong, Huafeng
>=20
> *Pull requests list:*
> GEARPUMP-11, fix code style
> https://github.com/gearpump/gearpump/pull/2032
>=20
> GEARPUMP-17, fix KafkaStorage lookup timestamp
> https://github.com/gearpump/gearpump/pull/2030
>=20
> GEARPUMP-10: Downgrade netty from Netty 4 to Netty 3.8 cause the OAuth2
> authentication failure
> https://github.com/gearpump/gearpump/pull/2029
>=20
> GEARPUMP-8, fix "two machines can possibly have same worker id "
> https://github.com/gearpump/gearpump/pull/2028
>=20
> GEARPUMP-9, Clean and fix integration test
> https://github.com/gearpump/gearpump/pull/2028
>=20
> GEARPUMP-6: show add/remove worker buttons for admin
> https://github.com/gearpump/gearpump/pull/2026
>=20
> GEARPUMP-5, Add additional authorization check like checking
> user-organization for cloudfoundry OAuth2 Authenticator.
> https://github.com/gearpump/gearpump/pull/2025
>=20
> GEARPUMP-3, Define REST API to add/remove worker instances, which allow u=
s
> to scale out in YARN
> https://github.com/gearpump/gearpump/pull/2024
>=20
> GEARPUMP-2, Define REST API to submit job jar
> https://github.com/gearpump/gearpump/pull/2023
>=20
> fix #1988, upgrade akka to akka 2.4.2
> https://github.com/gearpump/gearpump/pull/2017
>=20
> fix #2015, do not send AckRequest or LatencyProbe when there is no pendin=
g
> message in the channel
> https://github.com/gearpump/gearpump/pull/2016
>=20
> fix #1943 allow user to config how many executors to use in an applicatio=
n
> https://github.com/gearpump/gearpump/pull/1951
>=20
> fix #1641, add exactly-once integration test
> https://github.com/gearpump/gearpump/pull/2012
>=20
> fix #1318, fix MinClock not updated fast enough for slow stream
> https://github.com/gearpump/gearpump/pull/1705
>=20
> fix #1981, Support OAuth2 Social login
> https://github.com/gearpump/gearpump/pull/2005
>=20
> fix #2007, add Java DSL
> https://github.com/gearpump/gearpump/pull/2008
>=20
> fix #2002, add akka stream examples
> https://github.com/gearpump/gearpump/pull/2003
>=20
>=20
> Thanks
>=20
> Sean
>=20
>=20
>=C2=A0=20
 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0=C2=
=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=20

  
------=_Part_2490591_1886292194.1460558721661--