gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: DISCUSS: Review, and decide whether to accept additional code commit from github.com/gearpump
Date Thu, 14 Apr 2016 00:34:23 GMT
​github.com/gearpump/gearpump should be read only already, or you'll hit a
split-brain situation pretty fast I bet. (smile)
​

On Tue, Apr 12, 2016 at 9:27 PM, JiangWeihua <whjiang@outlook.com> wrote:

> I think we shall accept these commits in one batch and make github
> gearpump/gearpump read only afterwards.
>
> Sent from my iPhone
>
> > 在 2016年4月13日,12:17,Sean Zhong <clockfly@gmail.com> 写道:
> >
> > *Reason:*
> > During the waiting of initial code import to Apache, there are 19 PR
> > committed in old git repo github.com/gearpump.
> >
> > In this thread, we should DISCUSS whether we should import these 19 PR to
> > Apache git, which is
> > https://git-wip-us.apache.org/repos/asf/incubator-gearpump.git.
> >
> > We'd like to invite you to review the FAQ and PR list, to raise any
> > concerns if it exists.
> >
> > The discussion will open for 72 hours, after the discussion, a VOTE
> thread
> > will be called for the importing.
> >
> > *FAQ:*
> > 1. How long the transition happens?
> > We waited for about 28 days. The code commit happens in these past 28
> days.
> >
> > 2. How many PR are we talking about?
> > There are 17 PR covered. Start sha1: d5343681edde427022bf4c225ce602
> > 2a6904ae88, End sha1: 79e15668c6498a54da691626dd2f91bf205d3720
> >
> > 3. Whether they is important fix?
> > Yes, they fix many bugs and improve the features.
> >
> > 4. Whether these PR have reviews and +1 from initial Apache committers?
> > Yes, all these PRs have reviews and at least one +1 from Apache initial
> > committers.
> >
> > 5. Whether these code has good code style by Apache process?
> > Yes. Github.com/gearpump also have code style requirement, which is
> > consistent with Apache basic requirements.
> >
> > 6. Whether The ICLA are fired for the contributors of these PR?
> > Yes. All these 17 PR comes from Intel employees, the licensing is covered
> > by CCLA. The contributors list: Manu, Stanley Xu, Sean Zhong, Huafeng
> >
> > *Pull requests list:*
> > GEARPUMP-11, fix code style
> > https://github.com/gearpump/gearpump/pull/2032
> >
> > GEARPUMP-17, fix KafkaStorage lookup timestamp
> > https://github.com/gearpump/gearpump/pull/2030
> >
> > GEARPUMP-10: Downgrade netty from Netty 4 to Netty 3.8 cause the OAuth2
> > authentication failure
> > https://github.com/gearpump/gearpump/pull/2029
> >
> > GEARPUMP-8, fix "two machines can possibly have same worker id "
> > https://github.com/gearpump/gearpump/pull/2028
> >
> > GEARPUMP-9, Clean and fix integration test
> > https://github.com/gearpump/gearpump/pull/2028
> >
> > GEARPUMP-6: show add/remove worker buttons for admin
> > https://github.com/gearpump/gearpump/pull/2026
> >
> > GEARPUMP-5, Add additional authorization check like checking
> > user-organization for cloudfoundry OAuth2 Authenticator.
> > https://github.com/gearpump/gearpump/pull/2025
> >
> > GEARPUMP-3, Define REST API to add/remove worker instances, which allow
> us
> > to scale out in YARN
> > https://github.com/gearpump/gearpump/pull/2024
> >
> > GEARPUMP-2, Define REST API to submit job jar
> > https://github.com/gearpump/gearpump/pull/2023
> >
> > fix #1988, upgrade akka to akka 2.4.2
> > https://github.com/gearpump/gearpump/pull/2017
> >
> > fix #2015, do not send AckRequest or LatencyProbe when there is no
> pending
> > message in the channel
> > https://github.com/gearpump/gearpump/pull/2016
> >
> > fix #1943 allow user to config how many executors to use in an
> application
> > https://github.com/gearpump/gearpump/pull/1951
> >
> > fix #1641, add exactly-once integration test
> > https://github.com/gearpump/gearpump/pull/2012
> >
> > fix #1318, fix MinClock not updated fast enough for slow stream
> > https://github.com/gearpump/gearpump/pull/1705
> >
> > fix #1981, Support OAuth2 Social login
> > https://github.com/gearpump/gearpump/pull/2005
> >
> > fix #2007, add Java DSL
> > https://github.com/gearpump/gearpump/pull/2008
> >
> > fix #2002, add akka stream examples
> > https://github.com/gearpump/gearpump/pull/2003
> >
> >
> > Thanks
> >
> > Sean
>



-- 
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message