gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huafengw <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: fix GEARPUMP-41 check akka.schedu...
Date Wed, 27 Apr 2016 03:54:10 GMT
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/4#discussion_r61200851
  
    --- Diff: core/src/main/scala/io/gearpump/cluster/ClusterConfig.scala ---
    @@ -142,7 +142,7 @@ object ClusterConfig {
     
         if (!akka.util.Helpers.isWindows) {
     
    -      // Change the akka.scheduler.tick-duration to 10ms for Linux or Mac
    +      // Change the akka.scheduler.tick-duration to 1 ms for Linux or Mac
    --- End diff --
    
    That's different situations.
    When the cluster config is loaded, it will check the environment and ```akka.scheduler.tick-duration```
to make sure the ActorSystem can be launched correctly.
    
    However, when launching an application, the Config of Executor's ActorSytem is composed
of Worker's cluster config and application's config, and Worker's ```akka.scheduler.tick-duration```
could be overwrote by a wrong value. So another check here is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message