gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: fix GEARPUMP-41 check akka.schedu...
Date Wed, 27 Apr 2016 03:39:17 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/4#discussion_r61199826
  
    --- Diff: daemon/src/main/scala/io/gearpump/cluster/worker/Worker.scala ---
    @@ -361,12 +363,19 @@ private[cluster] object Worker {
             // Falls back to workerConfig
             .withFallback(workerConfig)
     
    +      // Minimum supported akka.scheduler.tick-duration on Windows is 10ms
    +      val duration = config.getInt(Constants.AKKA_SCHEDULER_TICK_DURATION)
    +      val updatedConf = if (akka.util.Helpers.isWindows && duration < 10)
{
    +        LOG.warn(s"akka.scheduler.tick-duration on Windows must be larger than 10ms,
set to 10ms")
    +        config.withValue(Constants.AKKA_SCHEDULER_TICK_DURATION, ConfigValueFactory.fromAnyRef(10))
    +      } else {
    --- End diff --
    
    but that check only applies for windows ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message