gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stanleyxu2005 <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request: Gearpump 36 fix gearpump doc buil...
Date Tue, 19 Apr 2016 12:17:31 GMT
Github user stanleyxu2005 commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/2#discussion_r60219536
  
    --- Diff: docs/build_doc.sh ---
    @@ -33,11 +34,19 @@ export BUILD_API=$2
     jekyll build
     
     # check html link validality
    +# htmlproof has been renamed to htmlproofer in Dec 2015
    +HTMLPROOF="htmlproof"
    +HTML_IGNORE_HREF='--href-ignore "#/"'
    +if ! `which $HTMLPROOF >/dev/null`; then
    +  HTMLPROOF="htmlproofer"
    +  HTML_IGNORE_HREF="--allow-hash-href"
    +fi
    +echo $HTMLPROOF
     echo "Checking generated HTMLs..."
    -htmlproof _site \
    +$HTMLPROOF _site \
       --disable-external \
    -  --href-ignore "#/" \
    -  --url-ignore \#,api/scala/index.html,api/java/index.html
    +  $HTML_IGNORE_HREF \
    +  --url-ignore \#,api/scala/index.html,api/java/index.html,/download.html
    --- End diff --
    
    Why download.html should pass the check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message