From notifications-return-5662-archive-asf-public=cust-asf.ponee.io@freemarker.apache.org Tue May 8 02:33:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B4D3118064D for ; Tue, 8 May 2018 02:33:03 +0200 (CEST) Received: (qmail 51040 invoked by uid 500); 8 May 2018 00:33:02 -0000 Mailing-List: contact notifications-help@freemarker.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@freemarker.apache.org Delivered-To: mailing list notifications@freemarker.apache.org Received: (qmail 51031 invoked by uid 99); 8 May 2018 00:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 00:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 59B391A2C8A for ; Tue, 8 May 2018 00:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id W4gXTiM5GhOV for ; Tue, 8 May 2018 00:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0C7925F1ED for ; Tue, 8 May 2018 00:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 490D9E0047 for ; Tue, 8 May 2018 00:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0B58D21297 for ; Tue, 8 May 2018 00:33:00 +0000 (UTC) Date: Tue, 8 May 2018 00:33:00 +0000 (UTC) From: "Mohamad zamri (JIRA)" To: notifications@freemarker.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FREEMARKER-96) StringTemplateLoader why check path security MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FREEMARKER-96?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1= 6466672#comment-16466672 ]=20 Mohamad zamri commented on FREEMARKER-96: ----------------------------------------- when i do this StringTemplateLoader stringLoader =3D new StringTemplateLoader(); cfg.setTemplateLoader(stringLoader); //=20 stringLoader.putTemplate("Template1", "Hello ${user} \n"); stringLoader.putTemplate("../Template2", "Hello ${user1} ${user2}"); //=20 Template temp1 =3D cfg.getTemplate("Template1"); Template temp2 =3D cfg.getTemplate("../Template2"); will get this exception freemarker.template.TemplateNotFoundException: Template not found for name = "../Template2". Reason given: Backing out from the root directory is not allowed. The name was interpreted by this TemplateLoader: StringTemplateLoader(Map {= "Template1"=3D..., "../Template2"=3D... }). ....... check root path why security is important I know, but it is StringTemplateL= oader not file right ? =20 > StringTemplateLoader why check path security > -------------------------------------------- > > Key: FREEMARKER-96 > URL: https://issues.apache.org/jira/browse/FREEMARKER-96 > Project: Apache Freemarker > Issue Type: Bug > Affects Versions: 2.3.28 > Environment: Java 8 > Reporter: bato > Priority: Major > > when i do this > StringTemplateLoader stringLoader =3D new StringTemplateLoader(); > cfg.setTemplateLoader(stringLoader); > //=C2=A0 > stringLoader.putTemplate("Template1", "Hello ${user} \n"); > stringLoader.putTemplate("../Template2", "Hello ${user1} ${user2}"); > //=20 > Template temp1 =3D cfg.getTemplate("Template1"); > Template temp2 =3D cfg.getTemplate("../Template2"); > will get this exception > freemarker.template.TemplateNotFoundException: Template not found for nam= e "../Template2". > Reason given: Backing out from the root directory is not allowed. > The name was interpreted by this TemplateLoader: StringTemplateLoader(Map= \{ "Template1"=3D..., "../Template2"=3D... }). > ....... > check root path why=C2=A0security is important I know, but it is=C2=A0Str= ingTemplateLoader not file right ? > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)