freemarker-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ddekany <...@git.apache.org>
Subject [GitHub] incubator-freemarker pull request #15: Configure Junit Tests Localization.
Date Sat, 31 Dec 2016 18:40:29 GMT
Github user ddekany commented on a diff in the pull request:

    https://github.com/apache/incubator-freemarker/pull/15#discussion_r94276569
  
    --- Diff: src/test/resources/freemarker/manual/CustomFormatsExample-alias1.ftlh ---
    @@ -16,6 +16,8 @@
       specific language governing permissions and limitations
       under the License.
     -->
    +<#setting locale="en_us">
    --- End diff --
    
    Indeed, but then the `locale` and `time_zone` should be set in the `ExamplesTest` class,
rather that in each template. Especially because otherwise the examples can't be copy-paster
from/to the Manual.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message