freemarker-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ddekany <...@git.apache.org>
Subject [GitHub] incubator-freemarker pull request #15: Configure Junit Tests Localization.
Date Sat, 31 Dec 2016 18:32:31 GMT
Github user ddekany commented on a diff in the pull request:

    https://github.com/apache/incubator-freemarker/pull/15#discussion_r94276468
  
    --- Diff: src/test/java/freemarker/core/OutputFormatTest.java ---
    @@ -322,14 +322,14 @@ public void testAutoEscapingSettingLayers() throws Exception {
         public void testNumericalInterpolation() throws IOException, TemplateException {
             getConfiguration().setRegisteredCustomOutputFormats(Collections.singleton(DummyOutputFormat.INSTANCE));
             assertOutput(
    -                "<#ftl outputFormat='dummy'>#{1.5}; #{1.5; m3}; ${'a.b'}",
    +                "<#ftl outputFormat='dummy'><#setting locale='en_US'>#{1.5};
#{1.5; m3}; ${'a.b'}",
    --- End diff --
    
    That's a good catch, but the locale should be simply set once in the `Configuration`,
rather that in each FTL snippet again and again. In fact, the `TemplateTest` should do that
automatically, as it's pointless to run tests with a random locale.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message