Mailing-List: contact notifications-help@freemarker.incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: dev@freemarker.incubator.apache.org
Date: Mon, 14 Mar 2016 15:24:33 +0000 (UTC)
From: =?utf-8?Q?Martin_T=C4=9Bthal_=28JIRA=29?= <jira@apache.org>
To: notifications@freemarker.incubator.apache.org
Message-ID: <JIRA.12949860.1457957518000.8754.1457969073650@Atlassian.JIRA>
In-Reply-To: <JIRA.12949860.1457957518000@Atlassian.JIRA>
References: <JIRA.12949860.1457957518000@Atlassian.JIRA>
 <JIRA.12949860.1457957518931@arcas>
Subject: [jira] [Comment Edited] (FREEMARKER-16) js_string buit-in function
 escapes '/' for first character
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/FREEMARKER-16?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1=
5193468#comment-15193468 ]=20

Martin T=C4=9Bthal edited comment on FREEMARKER-16 at 3/14/16 3:23 PM:
------------------------------------------------------------------

In our solution it is not neccessary to escape those combinations. It is ve=
ry similar to ?j_string where double-quotas are expected before and after
String x =3D "${val?j_string}";
but when we need to use single-quotation for attributes (JSTL on some Java =
EE servers needs only apostrophes for dynamic attributes) the string has to=
 escape both ' and ".
myattribute=3D'<%=3D "This string ${has?j_string} to be escaped with both" =
%>'
As Java strings suports both \' and \" (https://docs.oracle.com/javase/tuto=
rial/java/data/characters.html) my suggestion is to extend ?j_string to esc=
ape both.


was (Author: mtethal):
In our solution it is not neccessary to escape those combinations. It is ve=
ry similar to <tt>?j_string</tt> where double-quotas are expected before an=
d after
<tt>String x =3D "${val?j_string}";</tt>
but when we need to use single-quotation for attributes (JSTL on some Java =
EE servers needs only apostrophes for dynamic attributes) the string has to=
 escape both <tt>'</tt> and <tt>"</tt>.
<tt>myattribute=3D'<%=3D "This string ${has?j_string} to be escaped with bo=
th" %>'</tt>
As Java strings suports both <tt>\'</tt> and <tt>\"</tt> (https://docs.orac=
le.com/javase/tutorial/java/data/characters.html) my suggestion is to exten=
d <tt>?j_string</tt> to escape both.

> js_string buit-in function escapes '/' for first character
> ----------------------------------------------------------
>
>                 Key: FREEMARKER-16
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-16
>             Project: Apache Freemarker
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 2.3.23
>            Reporter: Martin T=C4=9Bthal
>            Assignee: Daniel Dekany
>            Priority: Minor
>
> ${"bar/foo"?js_string} returns "bar/foo"
> but
> ${"/foo"?js_string} returns "\/foo" (the first slash character is escaped=
 by backslash).
> I think the problem is from version 2.3.1 as documentation says:
> Starting from FreeMarker 2.3.1, it also escapes > as \> (to avoid </scrip=
t>).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)