freemarker-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woonsan <>
Subject [GitHub] incubator-freemarker pull request: FREEMARKER-1 OverrideResponseCo...
Date Sun, 11 Oct 2015 02:36:53 GMT
GitHub user woonsan opened a pull request:

    FREEMARKER-1 OverrideResponseContentType init param in FreemarkerServlet

    Added OverrideResponseContentType init param, setting it to true, for backward compatibility.
    Also, added a unit test with spring-test dependency (for easier servlet api mocking).
    Please take a review. (Once this accepted, FREEMARKER-2 should be easier because of the
unit test.)

You can merge this pull request into a Git repository by running:

    $ git pull feature/FREEMARKER-1-option-overrideResponseContentType

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
commit 93f1b4049667fdc955f071e8a9ea77d5ccc62ab3
Author: Woonsan Ko <>
Date:   2015-10-11T02:31:27Z

    FREEMARKER-1 adding OverrideResponseContentType init param in FreemarkerServlet


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message