freemarker-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FREEMARKER-2) Option to set request locale from the given servlet request
Date Mon, 26 Oct 2015 22:36:27 GMT

    [ https://issues.apache.org/jira/browse/FREEMARKER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975249#comment-14975249
] 

ASF GitHub Bot commented on FREEMARKER-2:
-----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-freemarker/pull/7


> Option to set request locale from the given servlet request
> -----------------------------------------------------------
>
>                 Key: FREEMARKER-2
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-2
>             Project: Apache Freemarker
>          Issue Type: Improvement
>            Reporter: Woonsan Ko
>            Priority: Minor
>
> Currently templates are executed with a specific global locale all the time because FreemarkerServlet.deduceLocale()
uses config.getLocale().
> This can result in wrong date/currency formatting issue for instance (when using JSTL
tags).
> It should be able to read HttpServletRequest#getLocale().
> Normally web application frameworks sets the request locale before rendering a view.
> Daniel's remark on this in old ML:
> {quote}
> Then, I think, the default implementation of deduceLocale() should take the a new init-param
into account, let's call it "LocaleFromRequest". The default of that should be false for backward
compatibility. But if someone sets that setting to true, and the request locale isn't null,
we use that instead of the Freemarker Configuration setting. And here again, you could override
what the
> *default* is.
> Just like with "OverrideResponseContentType", the default can depend
> on the IcI on the long run.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message