forrest-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Johannes Schaefer <johannes.schae...@uidesign.de>
Subject Re: How to create a patch for forrest
Date Wed, 04 Aug 2004 07:07:41 GMT
Hi!

I would like to create a new (better) patch,
but I get sth like this:

$>build patch
   BUILD FAILED
   D:\forrest\build.xml:366:
	The following error occurred while executing this line:
   D:\forrest\tools\targets\patch.xml:74:
	Please include the Apache Copyright header (for 2004)
	to these files and retry:
   D:\forrest\src\documentation\resources\images\apache-forrest.gif
   ...
   D:\forrest\src\documentation\resources\images\my_logo.jpg

How can I get around this? patch.txt gets generated, though.

Thanks,
Johannes

David Crossley wrote:

> Thanks for your effort Johannes. Yes it is better
> to have a separate patch and separate Jira issues.
> 
> See other notes at the FOR-236 issue.
> 
> --David
> 
> Johannes Schaefer wrote:
> 
>>Hi!
>>I put my first patch into the issue tracker,
>>see FOR-236 (adds support for sDocBook Note-Title
>>and adds a feedback link in the footer of the page).
>>Hope it works.
>>Maybe would have been better to separate them, though.
>>
>>Johannes
>>
>>Thorsten Scherler wrote:
>>
>>
>>>Hello all,
>>>
>>>please follow the steps I now describe if you like to create a patch. 
>>>This way it will be for all us very easy to apply your patches.
>>>
>>>1) Change your local forrest dis.
>>>
>>>2) Then run in top level dir:
>>>./build.sh patch or
>>>build.bat patch
>>>
>>>e.g. my forrest top level resides in /opt/apache/forrest:
>>>thorsten@gatos:/opt/apache/forrest$ ./build.sh patch
>>>
>>>3) You will see:
>>>Attach the following file to a new issue in the Forrest issue tracker:
>>>   patch.tar.gz if you have added new files
>>>   patch.txt if you have only modified existing files
>>>(Please review the patch first, to ensure that you have not added extra 
>>>stuff.)
>>>
>>>
>>>BUILD SUCCESSFUL
>>>
>>>Congratulations, that means you have created a patch :).
>>>
>>>4) Then open a new issue at 
>>>http://issues.cocoondev.org/jira/secure/CreateIssue!default.jspa (you 
>>>have be a register user and logged in) or add the file to a existing issue.
>>>
>>>If you add it to an existing issue and there are more then one 
>>>attachment it may makes sense to rename the file like e.g. 
>>>patch.css-style.txt.
>>>
>>>Some tips:
>>>
>>>* Make sure that your forrest SVN working copy
>>>is up-to-date (svn update).
>>>* Keep the same text indentation as in the files that
>>>you are working on.
>>>
>>>* Make sure that your xml files and stylesheets are
>>>valid xml.
>>>
>>>HTH
>>>thorsten
> 
> 

-- 
User Interface Design GmbH * Teinacher Str. 38 * D-71634 Ludwigsburg
Fon +49 (0)7141 377 000 * Fax  +49 (0)7141 377 00-99
Geschäftsstelle: User Interface Design GmbH * Lehrer-Götz-Weg 11 * 
D-81825 München
www.uidesign.de

Mime
View raw message