forrest-svn mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thorsten.scher...@wyona.com>
Subject Re: svn commit: r423454 - /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Date Wed, 19 Jul 2006 13:37:10 GMT
El mié, 19-07-2006 a las 13:01 +0000, cdupoirieux@apache.org escribió:
> Author: cdupoirieux
> Date: Wed Jul 19 06:01:17 2006
> New Revision: 423454
> 
> URL: http://svn.apache.org/viewvc?rev=423454&view=rev
> Log:
> FOR-893 - We have encountered a strange problem with the pattern 'resolve.structurer.**'.
> The {1} sometimes matches nothing, whereas {../1} is OK.
> On the contrary, the {../1} sometimes matches nothing, whereas {1} is OK.
> As a temporary workaround, we put {../1}{1} which covers all the cases.
> 
> Modified:
>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
> 
> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml?rev=423454&r1=423453&r2=423454&view=diff
> ==============================================================================
> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
(original)
> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Wed Jul 19 06:01:17 2006

...
> @@ -142,18 +150,18 @@
>        <select type="exists">
>          <!-- project-based 
>            url-based (url location) -->
> -        <location src="{project:resources}/structurer/url/{1}{project:theme-ext}"
/>
> +	  <location src="{project:resources}/structurer/url/{../1}{1}{project:theme-ext}"
/>
>  

I think we should not apply the workaround to locations that are not
effected by this weirdness. 

The problem occurs only in actions that have an xpath like
select/action/parameter. 

For example the select/action[@type='sourcetype'] is working like a
charm with {1} in @src.

Maybe it would be the best to adjust the
action[@type='resourceTypeAction'] and
action[@type='RecursiveDirectoryTraversalAction'] to add a @src='{1}'
and change the processing in the java to use the @src instead of the
<parameter value="{../1}" name="request"/>.

However the whole issue smells really fishy and we need to get to the
bottom of this issue.

My problem is that I need to setup a test project to *see* the bug.

Maybe you can attach a small project to the issue that I can test?

salu2
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org


Mime
View raw message