forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian M Dube <bd...@apache.org>
Subject Re: [GitHub] forrest pull request #1: Trivial typo
Date Wed, 22 Mar 2017 02:33:47 GMT
Sorry moderators. Resending from the correct address...

On 03/21/2017 05:55 PM, Brian M Dube wrote:
> On 03/20/2017 08:09 PM, David Crossley wrote:
>> Ah, i do not know. There must be some docs at ASF Infra.
>> I do know that the process has been refined and is ready now.
>>
>> We should have sorted ourselves before the first pull request.
>>
>> One issue will be that that mirror is way out-of-date. I presume that
>> it is still from the initial experiment many years ago.
> 
> The github mirror is out of date, and it's unclear to me why that is.
> Github mirrors git://git.apache.org/forrest.git and that in turn is
> supposed to keep up with our main svn location. But that's not happening.

It's not happening because once upon a time in our svn history, we had a
branch name that was allowed by svn but disallowed by git. So now the
mirroring process with branches enabled cannot continue. Infra has
disabled branches for our mirror for the time being so that we can at
least sync svn trunk to git and deal with the current pull request.

Details at https://issues.apache.org/jira/browse/INFRA-13719

My chat with infra also answered the question about contributions.
Membership in the github.com/apache organization does signify that ICLA
is on file and there is no issue accepting such a user's work.

>> Also we need the notifications to go to our svn@ list, not dev.
> 
> Do you mean pull requests like the one below should go to svn@, or just
> commits?

It looks like this is handled at the Service Desk under Github Integration.

https://issues.apache.org/jira/servicedesk/customer/portal/1

> Brian
> 
>> That should have been called "commits" or some such. Perhaps need an alias.
>>
>> -David
>>
>> On Mon, Mar 20, 2017 at 04:30:16PM -0700, Brian M Dube wrote:
>>> Thank you, kinow.
>>>
>>> So how does this work? I can see that github user kinow is a member of
>>> the github.com/apache organization. There is also a kinow@apache.org
>>> with matching name. Is that all we need to know to accept and attribute
>>> commits from github?
>>>
>>> Brian
>>>
>>> On 03/19/2017 04:57 AM, kinow wrote:
>>>> GitHub user kinow opened a pull request:
>>>>
>>>>     https://github.com/apache/forrest/pull/1
>>>>
>>>>     Trivial typo
>>>>
>>>>     
>>>>
>>>> You can merge this pull request into a Git repository by running:
>>>>
>>>>     $ git pull https://github.com/kinow/forrest trunk
>>>>
>>>> Alternatively you can review and apply these changes as the patch at:
>>>>
>>>>     https://github.com/apache/forrest/pull/1.patch
>>>>
>>>> To close this pull request, make a commit to your master/trunk branch
>>>> with (at least) the following in the commit message:
>>>>
>>>>     This closes #1
>>>>     
>>>> ----
>>>> commit 857a0eaaf8c17c5c17e690258a99905ff29879fa
>>>> Author: Bruno P. Kinoshita <kinow@users.noreply.github.com>
>>>> Date:   2017-03-19T11:56:57Z
>>>>
>>>>     Trivial typo
>>>>
>>>> ----
>>>>
>>>>
>>>> ---
>>>> If your project is set up for it, you can reply to this email and have your
>>>> reply appear on GitHub as well. If your project does not have this feature
>>>> enabled and wishes so, or if the feature is enabled but not working, please
>>>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>>>> with INFRA.
>>>> ---
>>>>
>>>

Mime
View raw message