forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Williams (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-986) Dispatcher war fails to build if no skinconf.xml is in place
Date Tue, 27 Apr 2010 13:01:40 GMT

    [ https://issues.apache.org/jira/browse/FOR-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861387#action_12861387
] 

Tim Williams commented on FOR-986:
----------------------------------

I started about resolving this as it seemed easy enough.  The obvious solution is to only
attempt loading it if it's not a dispatcher site, but since dispatcher is currently a plugin,
it seems weird checkin for it in the core build.  

Seems to me we've got options:

1) If skinconf isnt' there, don't complain in any case.  This would break any non-dispatcher
sites but since we include it in most seeds, it's only likely to occur in cases where folks
know what they're doing (ie. they explicitly deleted the skinconf).

2) Check if it's a dispatcher enabled site and, if so, don't complain about it missing.  This
would violate a separation of concerns between core->plugins and, generally, be dirty.

3) Punt until we figure out how dispatcher lands in core.  A valid workaround exists and the
problem has to be actively caused (by deleting skinconf).

Thoughts?

> Dispatcher war fails to build if no skinconf.xml is in place
> ------------------------------------------------------------
>
>                 Key: FOR-986
>                 URL: https://issues.apache.org/jira/browse/FOR-986
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.8
>            Reporter: Ross Gardler
>            Priority: Critical
>             Fix For: 0.9-dev
>
>
> A dispatcher based site does not need a skinconf.xml file. However, if one is not present
then the "forrest war" target fails with:
> BUILD FAILED
> C:\projects\apache-forrest-0.8\main\targets\webapp.xml:48: The following error occurred
while executing this line:
> C:\projects\apache-forrest-0.8\main\forrest.build.xml:256: input file C:\projects\apache-forrest-0.8\main\webapp\skinconf.xml
does not exist
> To work around this issue just put a skinconf.xml in place

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message