Return-Path: 
 <dev-return-30370-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 49708 invoked from network); 10 May 2009 23:23:08 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 10 May 2009 23:23:08 -0000
Received: (qmail 73094 invoked by uid 500); 10 May 2009 23:23:08 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 72992 invoked by uid 500); 10 May 2009 23:23:07 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 72984 invoked by uid 99); 10 May 2009 23:23:07 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2009 23:23:07 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2009 23:23:05 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 90304234C041
	for <dev@forrest.apache.org>; Sun, 10 May 2009 16:22:45 -0700 (PDT)
Message-ID: <1719996393.1241997765576.JavaMail.jira@brutus>
Date: Sun, 10 May 2009 16:22:45 -0700 (PDT)
From: "Gavin (JIRA)" <jira@apache.org>
To: dev@forrest.apache.org
Subject: [jira] Commented: (FOR-1154) Skins test site page fails HTML
 validation
In-Reply-To: <519573933.1231843144267.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/FOR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707855#action_12707855 ] 

Gavin commented on FOR-1154:
----------------------------

Note that the 'figure' element has as an optional 'id' attribute. This 'id' attribute is generated from document-to-html.xsl. However it generates the same given 'id' attribute for both the generated img element and its surrounding div element and duplicate id's are not allowed.

I'm going to change this behaviour to add '-figure' to the end of the figure id if one is given to keep the id's unique. I'll leave the 'id' attribute as optional but also change it to not generate a blank id if none is given, as is the case currently.

> Skins test site page fails HTML validation
> ------------------------------------------
>
>                 Key: FOR-1154
>                 URL: https://issues.apache.org/jira/browse/FOR-1154
>             Project: Forrest
>          Issue Type: Bug
>          Components: Example Sites, Skins (general issues)
>    Affects Versions: 0.9-dev
>            Reporter: Gavin
>            Assignee: Gavin
>             Fix For: 0.9-dev
>
>
> Currently, the sample page fails validation for HTML in two places.
> Error  Line 666, Column 9: syntax of attribute value does not conform to declared value.
> <div id="" style="text-align: center;">
> Line 667, Column 9: syntax of attribute value does not conform to declared value.
> <img id="" class="figure" alt="The fine Forrest logo" src="images/project-logo.p
> Full details at :-
> http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fforrest.zones.apache.org%2Fft%2Fbuild%2Fforrest-seed%2Fsamples-b%2Fsample.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.