forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin" <ga...@16degrees.com.au>
Subject RE: recent CSS changes side-effect (Was: svn commit: r733561)
Date Mon, 12 Jan 2009 22:41:10 GMT


> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Tuesday, 13 January 2009 7:56 AM
> To: Forrest Developers List
> Subject: recent CSS changes side-effect (Was: svn commit: r733561)
> 
> > Author: gmcdonald
> > Date: Sun Jan 11 17:03:05 2009
> > New Revision: 733561
> >
> > URL: http://svn.apache.org/viewvc?rev=733561&view=rev
> > Log:
> > Move 2nd level tabs to correct location
> >
> > Modified:
> >
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css
> >
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml
> >
> > Modified:
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css
> > URL:
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/pelt/css/pelt.screen.css?rev=733561&r1=733560&r2
> =733561&view=diff
> >
> ==========================================================================
> ====
> > ---
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css (original)
> > +++
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> > @@ -210,6 +210,7 @@
> >      padding-left: 10px;
> >      margin: 0;
> >      list-style: none;
> > +    padding-top:18px;
> >  }
> 
> Why introduce this big gap at the top of the left-hand menu
> for all pages?

Hmm, any chance of a screenshot?

I'm not seeing a big gap anywhere, tested in Firefox 2 (win and linux),
Firefox 3 (win and linux), IE7 (win), Opera (win) and Safari (win)

The change was introduced, because locally during a forrest run and forrest
site , and confirmed on forrest.zones - the 2nd level tabs once positioned
correctly in the last-published area, were hidden from view behind the
leftnav, this was in IE only, in others I cured it by use of z-index to
bring the 2nd level tabs to the top, IE was not affected by this change.

So by bringing the leftnav down by 18px it revealed the hidden 2nd level
tabs on IE, whilst still being attached to the top nav area, so no gaps.

At least that's how it tests on my 3 monitors of varied resolutions, 2
operating systems, and 5 web browsers. Not having a genuine MAC I can't test
on that.

Level 2 tabs have been broken for quite some time, appearing out of place on
the same row as the main tabs, to me now, they are correctly positioned from
the work of the last day or two (not just by the padding-top addition you
point out above.)

In case you can't get a screenshot to me, I'll submit the forrest.zones to
browsershots and see what that comes up with.

Gav...

> 
> -David
> 
> >  #nav-main li {
> > @@ -285,6 +286,7 @@
> >      float:left;
> >      position:relative;
> >      background-color: #4A6D8C ;
> > +    z-index:30;
> >  }
> >  #level2tabs a {padding-right: 5px;
> >  background-color: #CFDCED;
> >
> > Modified:
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml
> > URL:
> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
> orrest.themes.core/themes/pelt/panels/pelt-html.nav-
> main.panel.xml?rev=733561&r1=733560&r2=733561&view=diff
> >
> ==========================================================================
> ====
> > ---
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml (original)
> > +++
> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> t/panels/pelt-html.nav-main.panel.xml Sun Jan 11 17:03:05 2009
> > @@ -28,9 +28,9 @@
> >    <forrest:hook name="nav-main-hook">
> >      <forrest:contract name="nav-main"
> >        dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> > +    <forrest:hook name="publishedStrip" nbsp="true">
> >  <forrest:contract name="nav-main-sub"
> >          dataURI="cocoon://#{$getRequest}.navigation.xml"/>
> > -    <forrest:hook name="publishedStrip" nbsp="true">
> >        <forrest:contract name="siteinfo-last-published"/>
> >      </forrest:hook>
> >    </forrest:hook>
> >
> >
> >
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.6/1888 - Release Date: 1/12/2009
> 7:04 AM


Mime
View raw message