forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: recent CSS changes side-effect (Was: svn commit: r733561)
Date Tue, 13 Jan 2009 00:08:41 GMT
Gavin wrote:
> From: David Crossley
> > forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
> > t/css/pelt.screen.css Sun Jan 11 17:03:05 2009
> > > @@ -210,6 +210,7 @@
> > >      padding-left: 10px;
> > >      margin: 0;
> > >      list-style: none;
> > > +    padding-top:18px;
> > >  }
> > 
> > Why introduce this big gap at the top of the left-hand menu
> > for all pages?
> 
> Hmm, any chance of a screenshot?

It can be seen at http://forrest.zones.apache.org/ft/build/forrest-sample-2/
i.e. the Dispatcher-based site.
On all pages, the left-hand menu is now 18 pixels lower.
See the now bigger blue section (gap) at the top.

The amount of room available in the side menu is limited.
We cannot afford to move it even further down the page.

-David

> I'm not seeing a big gap anywhere, tested in Firefox 2 (win and linux),
> Firefox 3 (win and linux), IE7 (win), Opera (win) and Safari (win)
> 
> The change was introduced, because locally during a forrest run and forrest
> site , and confirmed on forrest.zones - the 2nd level tabs once positioned
> correctly in the last-published area, were hidden from view behind the
> leftnav, this was in IE only, in others I cured it by use of z-index to
> bring the 2nd level tabs to the top, IE was not affected by this change.
> 
> So by bringing the leftnav down by 18px it revealed the hidden 2nd level
> tabs on IE, whilst still being attached to the top nav area, so no gaps.
> 
> At least that's how it tests on my 3 monitors of varied resolutions, 2
> operating systems, and 5 web browsers. Not having a genuine MAC I can't test
> on that.
>
> Level 2 tabs have been broken for quite some time, appearing out of place on
> the same row as the main tabs, to me now, they are correctly positioned from
> the work of the last day or two (not just by the padding-top addition you
> point out above.)
> 
> In case you can't get a screenshot to me, I'll submit the forrest.zones to
> browsershots and see what that comes up with.
> 
> Gav...

Mime
View raw message