forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin" <ga...@16degrees.com.au>
Subject RE: possible typos in todays changes (Was: svn commit: r734537)
Date Thu, 15 Jan 2009 00:37:46 GMT


> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Thursday, 15 January 2009 9:52 AM
> To: Forrest Developers List
> Subject: possible typos in todays changes (Was: svn commit: r734537)
> 
> I only glanced over this commit - not much time lately.
> However i saw what looks like one typo in the changes
> for the "dtdx" plugin. See below.

Thanks for spotting that.

> 
> I know that it is a lot of effort to test each one as you go.
> I have needed to do something similar many times before.
> If we don't test, then we all need to take extra care with
> reviewing the commits.

Yeah, I did test some randomly but admit to not testing them all.

With the dtdx one in particular, I used a perl -p -i -e command to find and
replace, as a test to bulk do them all. However I then abandoned that in
favour of altering each one manually checking for other things along the
way. I guess my typo came from the rather long perl command.

> 
> I wonder if we can find a way to test all plugins with
> something akin to the current 'main/build.sh test'.

That would be good, I'm not sure I'm the one to be able to do that but I'll
take a look and see what's involved.

> 
> That would then be very useful if ever we get going
> again with Apache Gump and some other continuous integration.

Hopefully soon, Hudson and Buildbot will be in use on 4 new build machines,
I'll certainly try and get forrest included into one of those.

Gav...

> 
> > Author: gmcdonald
> > Date: Wed Jan 14 14:38:16 2009
> > New Revision: 734537
> >
> > URL: http://svn.apache.org/viewvc?rev=734537&view=rev
> > Log:
> > Expand src for windows users - FOR-1108
> >
> > Modified:
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.OpenOffice.org/locat
> ionmap.xml
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.PhotoGallery/locatio
> nmap.xml
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.dtdx/locationmap.xml
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.excel/locationmap.xm
> l
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.feeder/locationmap.x
> ml
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.listLocations/locati
> onmap.xml
> >
> forrest/trunk/plugins/org.apache.forrest.plugin.input.wiki/locationmap.xml
>  [ snip ]
> >      <match pattern="dtdx.transform.*.*">
> > -      <location src="resources/stylesheets/{1}-to-{2}.xsl" />
> > +      <select>
> > +        <location src="resources/stylesheets/{1}-to-{2}.xsl" />
> > +        <location
> src="{forrest:forrest.plugins}/org.apache.forrest.plugin.input.dtdx/resour
> ces/stylesheets/{1}-to{2}.xsl" />
> 
> Should that be "-to-"?
> 
> -David
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG.
> Version: 7.5.552 / Virus Database: 270.10.7/1893 - Release Date: 1/14/2009
> 6:59 AM


Mime
View raw message