forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin" <ga...@16degrees.com.au>
Subject RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows
Date Wed, 03 Dec 2008 11:52:56 GMT


> -----Original Message-----
> From: Gavin [mailto:gavin@16degrees.com.au]
> Sent: Wednesday, 3 December 2008 9:31 PM
> To: dev@forrest.apache.org
> Subject: RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and
> Windows
> 
> 
> 
> > -----Original Message-----
> > From: David Crossley [mailto:crossley@apache.org]
> > Sent: Wednesday, 3 December 2008 11:03 AM
> > To: dev@forrest.apache.org
> > Subject: Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and
> > Windows
> >
> > Thorsten Scherler wrote:
> > > Gavin wrote:
> > > ...
> > > >
> > > > Thanks, it also happens to be a (not necessarily the) fix for
> getting
> > trunk
> > > > working again for Windows Devs. We need to look a bit higher up in
> the
> > chain
> > > > as to what makes this work and if we can find a solution without
> > having to
> > > > have this fallback permanently in all plugins, current and future.
> > >
> > > Actually it maybe our bug after all. Looking at my commit you pointed
> > > out it feels right to have a non relative match as fallback. I mean
> the
> > > relative match in the lm is for the rare case that one is requesting
> the
> > > plugin directly or one needs a custom implementation of the match.
> > > However relative path for plugins means: one cannot reuse the lm match
> > > from a project or plugin without implementing the match.
> > >
> > > ...and that does not feel right and more like a bug.
> > >
> > > > I don't know why, I just have the niggling feeling that because it
> > works
> > > > without this fix for Linux/MAC then applying the above fix for
> Windows
> > feels
> > > > to me like a hack.
> > >
> > > The above discussed is not a hack but a clear enhancement. Well e.g.
> > > {forrest:forrest.plugins}/org.apache.forrest.plugin.output.Text/
> should
> > > be replaced by something shorter. Awesome would be {this} but not sure
> > > whether that is easily to implement.
> >
> > Don't forget that this would need to be handled by the
> > Ant target that creates a new plugin from the template:
> > http://forrest.apache.org/docs/dev/howto/howto-buildPlugin.html#seed
> 
> I was thinking if they are required lines we could just add them in to the
> template directly so that they are there already, does that sound ok?

Hmm, I'll expand on that.

In the pluginTemplate we can add commented out example code to
locationmap.xml like :-

  <locator>
<!-- Uncomment the below matches once you have a stylesheet you wish to use.
Note that these are needed for the plugin to work on windows. See FOR-1108
-->
  <!-- 
  <match pattern="plugin.transform.*.*">
     <select>
       <location src="resources/stylesheets/{1}-to-{2}.xsl" />
         <location
src="{forrest:forrest.plugins}/@plugin-name@/resources/stylesheets/{1}-to-{2
}.xsl"/>
     </select>
   </match> 
   -->
 </locator>

Currently the <locator /> is empty. Then once a stylesheet has been created
the dev can uncomment out the example.

Gav...


> 
> If so I'll do all this tomorrow.
> 
> Gav...
> 
> >
> > -David
> >
> >
> > --
> > Internal Virus Database is out-of-date.
> > Checked by AVG.
> > Version: 7.5.549 / Virus Database: 270.9.3/1787 - Release Date:
> 11/14/2008
> > 8:32 AM
> 
> 
> 
> --
> Internal Virus Database is out-of-date.
> Checked by AVG.
> Version: 7.5.549 / Virus Database: 270.9.3/1787 - Release Date: 11/14/2008
> 8:32 AM


Mime
View raw message