forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <rgard...@apache.org>
Subject Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows
Date Thu, 04 Dec 2008 00:54:52 GMT

On 2 Dec 2008, at 11:52, Gavin wrote:

>
>
>> -----Original Message-----
>> From: Thorsten Scherler [mailto:thorsten.scherler.ext@juntadeandalucia.es 
>> ]
>> Sent: Tuesday, 2 December 2008 9:43 PM
>> To: dev@forrest.apache.org
>> Subject: RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and
>> Windows
>>
>> El lun, 01-12-2008 a las 12:04 +1000, Gavin escribió:
>> ...
>>> I checked the PDF plugin again as this was never broken on Windows  
>>> and
>> found
>>> that the exact same fix we recently found we needed to do to other
>> plugins
>>> was already present in the PDF plugin.
>>>
>>> Thorsten committed this change back in February 18th [1] with the  
>>> log
>>> message of 'making resources usable from other plugins' .
>> ...
>>>
>>> [1] -
>>>
>> http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plug
>> in
>>> .output.pdf/locationmap.xml?r1=628558&r2=628586&diff_format=h
>>
>> Yeah, actually if we want to reuse resources from other plugins the
>> relative path does not work in the lm for plugins.
>>
>> The solution to add as fallback the absolute location will work for  
>> all
>> plugin as I understand it and brings the benefit of usability of the
>> resources.
>>
>

...

> However, if the above fix is useful in general for making reusable  
> resources
> available by default then it doesn't feel so bad. Combine that with  
> talk of
> future and markably different direction(s) for Forrest as a whole  
> then it
> might just be acceptable.

+1

Thorsten and I talked about the solution for reusing resources some  
time ago. The result was his commit you refer to.

A side effect that fixes a weird bug on a single platform is a plus.  
It is well documented thanks to your work and the discussion here and  
on the JIRA issue. I'd just make the patch and be done with it.

If it bites us in the ass in the future we can revisit.

Ross
Mime
View raw message