forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin" <ga...@16degrees.com.au>
Subject RE: svn commit: r700307 -/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Date Mon, 06 Oct 2008 12:06:40 GMT


> -----Original Message-----
> From: Thorsten Scherler [mailto:thorsten.scherler.ext@juntadeandalucia.es]
> Sent: Monday, 6 October 2008 8:39 PM
> To: dev@forrest.apache.org
> Subject: Re: svn commit: r700307 -
> /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispa
> tcher/locationmap.xml
> 
> On Mon, 2008-10-06 at 12:29 +0200, Thorsten Scherler wrote:
> > On Mon, 2008-09-29 at 23:37 +0000, gmcdonald@apache.org wrote:
> > > Author: gmcdonald
> > > Date: Mon Sep 29 16:37:33 2008
> > > New Revision: 700307
> > >
> > > URL: http://svn.apache.org/viewvc?rev=700307&view=rev
> > > Log:
> > > Alter remaining matches to use lm:
> >
> > I agree with the indention of this commit, however:
> >
> >
> > > +     <!--+
> > > +         | resources home
> > > +         +-->
> > > +    <match pattern="resources.home">
> > > +      <location src="{properties:resources}"/>
> > > +    </match>
> > >      <!--+
> > >          |  Base location of the project themes
> > >          +-->
> > >      <match pattern="themer.project.dir">
> > > -      <location src="{properties:resources}/themes" />
> > > +      <location src="{lm:resources.home}/themes" />
> > >      </match>
> >
> > This is not the same: the above will result in // since
> > {properties:resources} is ending with "/"
> 
> Meaning that project-based structurer matching should not work anymore.

ah, thanks for checking, I'll correct that (and check or any more)

Gav...

> 
> salu2
> 
> > ...
> > > -
> src="{properties:resources}stylesheets/xslt/html/{1}.xsl"
> > > +
> src="{lm:resources.home}stylesheets/xslt/html/{1}.xsl"
> > >                      />
> >
> > Here it is correct again.
> >
> > salu2
> --
> Thorsten Scherler                                 thorsten.at.apache.org
> Open Source Java                      consulting, training and solutions
> 
> 
> --
> Internal Virus Database is out-of-date.
> Checked by AVG.
> Version: 7.5.524 / Virus Database: 270.6.21 - Release Date: 9/11/2008
> 12:00 AM


Mime
View raw message