forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thorsten.scherler....@juntadeandalucia.es>
Subject Themes should be copyless (was Re: svn commit: r697661)
Date Wed, 08 Oct 2008 10:07:58 GMT
On Mon, 2008-09-22 at 03:46 +0000, gmcdonald@apache.org wrote:
> Author: gmcdonald
> Date: Sun Sep 21 20:46:00 2008
> New Revision: 697661
> 
> URL: http://svn.apache.org/viewvc?rev=697661&view=rev
> Log:
> A maven theme, for that like the look but still like to build with forrest

This commit duplicated various resources. Further it seems that it is a exact 
copy of the pelt theme but it has not been done with "svn cp". This looses 
important information from where it is coming from.

I could find http://svn.apache.org/viewvc?rev=697836&view=rev and 
http://svn.apache.org/viewvc?rev=700349&view=rev where you modify some files:
maven.screen.css and maven-html.content.panel.xml

Meaning the rest of the files are duplication that we now need to maintain. 
The dispatcher has been written to actually overcome this kind of code duplications.

If you need to reuse contracts of pelt the best is to promote them to common and not 
copy them.

In this case it seems the most important changes has been done in the css and not in
the structurer. It may would be the best to incorporate the maven theme directly into pelt.

Are you aware of branding-theme-switcher?

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Mime
View raw message