Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 83630 invoked from network); 1 Sep 2008 20:22:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Sep 2008 20:22:44 -0000 Received: (qmail 80719 invoked by uid 500); 1 Sep 2008 20:22:42 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 80659 invoked by uid 500); 1 Sep 2008 20:22:42 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@forrest.apache.org List-Id: Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 80648 invoked by uid 99); 1 Sep 2008 20:22:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Sep 2008 13:22:42 -0700 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [129.67.1.161] (HELO relay0.mail.ox.ac.uk) (129.67.1.161) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Sep 2008 20:21:43 +0000 Received: from smtp1.mail.ox.ac.uk ([129.67.1.207]) by relay0.mail.ox.ac.uk with esmtp (Exim 4.69) (envelope-from ) id 1KaFue-0004oJ-1o for dev@forrest.apache.org; Mon, 01 Sep 2008 21:22:12 +0100 Received: from host81-154-98-94.range81-154.btcentralplus.com ([81.154.98.94] helo=[192.168.1.74]) by smtp1.mail.ox.ac.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KaFue-00033y-4f for dev@forrest.apache.org; Mon, 01 Sep 2008 21:22:12 +0100 Message-ID: <48BC5073.5090200@apache.org> Date: Mon, 01 Sep 2008 21:28:35 +0100 From: Ross Gardler User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: dev@forrest.apache.org Subject: Re: output.inputModule Plugin dependency References: <486E95D6.4010702@apache.org> <1219302395.21107.68.camel@thorsten-desktop> <41D45BDD-62D1-4A8D-BD65-80A6363674B2@mac.com> <499888440808210309o2c7bf309o1440635ac5040097@mail.gmail.com> <2B042A39-E359-48E9-842A-0B8E30082B8A@mac.com> <1219388451.19104.43.camel@thorsten-desktop> <48AF2DE8.8010902@apache.org> <1220267963.6404.45.camel@thorsten-desktop> In-Reply-To: <1220267963.6404.45.camel@thorsten-desktop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Oxford-Username: oucs0040 X-Virus-Checked: Checked by ClamAV on apache.org Thorsten Scherler wrote: > On Mon, 2008-09-01 at 13:40 +0300, Sjur Moshagen wrote: ... >> I agree with Ross that the easiest solution would be to just move the >> code to core. > > Yeah, it is just one generator. It is fine with me to move this class > directly to the core, best solution IMO is to leave it in the plugin > structure but build it by default with the core. Meaning we can drop the > dependency in the required plugin section. > > However ATM I cannot look into the needed changes for that. I am fine > with either move the class directly to the core or generate the jar once > and add it to the lib dir. In both cases we need the one match that the > plugin offers in the main sitemap. Looks like we have a solution then. I don't understand the motivation for leaving the code in a plugin but building it with core, I'm -0 on that. Easiest solution is certainly just to take the code into core and lose the plugin, I'm +0 for that. Ross