Return-Path: 
 <dev-return-29624-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 84599 invoked from network); 11 Sep 2008 16:13:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 11 Sep 2008 16:13:21 -0000
Received: (qmail 46588 invoked by uid 500); 11 Sep 2008 16:13:18 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 46536 invoked by uid 500); 11 Sep 2008 16:13:18 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 46525 invoked by uid 99); 11 Sep 2008 16:13:18 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2008 09:13:18 -0700
X-ASF-Spam-Status: No, hits=0.2 required=10.0
	tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [66.111.4.27] (HELO out3.smtp.messagingengine.com)
 (66.111.4.27)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2008 16:12:19 +0000
Received: from compute1.internal (compute1.internal [10.202.2.41])
	by out1.messagingengine.com (Postfix) with ESMTP id CC2EB15ED69
	for <dev@forrest.apache.org>; Thu, 11 Sep 2008 12:12:49 -0400 (EDT)
Received: from heartbeat2.messagingengine.com ([10.202.2.161])
  by compute1.internal (MEProxy); Thu, 11 Sep 2008 12:12:49 -0400
X-Sasl-enc: HAbC9/mJakFtOI+m5xHFvvlpTIF/88z0VG57PL+LlcqG 1221149558
Received: from localhost (dsl-41-216.nsw1.net.au [125.168.41.216])
	by mail.messagingengine.com (Postfix) with ESMTPSA id 244C52A043
	for <dev@forrest.apache.org>; Thu, 11 Sep 2008 12:12:37 -0400 (EDT)
Date: Fri, 12 Sep 2008 02:12:27 +1000
From: David Crossley <crossley@apache.org>
To: dev@forrest.apache.org
Subject: Re: i18n message catalogue in dispatcher and skins
Message-ID: <20080911161227.GV2534@igg.indexgeo.com.au>
References: <62431B7F-E72E-40E2-A8F9-8F8953EFF43A@mac.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <62431B7F-E72E-40E2-A8F9-8F8953EFF43A@mac.com>
User-Agent: Mutt/1.4.2.2i
X-Virus-Checked: Checked by ClamAV on apache.org

Sjur Moshagen wrote:
> 
> I'm starting on the next step to make the pdf plugin fully i18n -  
> support for i18n text.
> 
> To that extent I have a couple of questions:
> 
> 1.
> 
> In $FORREST_HOME/main/webapp/sitemap.xmap, the following lines are  
> found:
> 
>       <map:transformer name="i18n"  
> src="org.apache.cocoon.transformation.I18nTransformer">
>         <catalogues default="common">
>           <catalogue id="common" name="CommonMessages"  
> location="{properties:skins-dir}common/translations"/>
>         </catalogues>
>         <cache-at-startup>true</cache-at-startup>
>       </map:transformer>
> 
> Why is the path to the message catalogue "soft-coded" to the project  
> instead of using a LM?

When the locationmap was introduced we tried to
methodically go through all the plugins to
utilise the locationmaps. However, i don't recall
us doing that methodically in core. We need
another scan through everything.

> 2.
> 
> Dispatcher has its own set of translations in
> 
> $FORREST_HOME/whiteboard/plugins/o.a.f.plugin.internal.dispatcher/ 
> resources/stylesheets/common/translations/
> 
> The files there seem to be exact copies of the ones in
> 
> $FORREST_HOME/main/webapp/skins/common/translations/
> 
> Any reason for the duplication? Why not use the skins catalogue?

There is a lot of stuff that got duplicated when
the dispatcher work started, e.g. sitemaps.
Not criticising, there seemed to be no other way.
I recall expressing concern over how to keep
stuff synchronised.

So anything that can be done to ease that is good.

> 3. Both dispatcher and skins seem to prefer translations in the  
> project tree. Why is that? To ease setup for new languages for new  
> users (understandable)? It would still be quite easy to use some LM to  
> fall back to a message catalogue in forrest if not found in the  
> project, and just tell users to copy the files into the proper project  
> folder if needed (ie when needing support for a language not yet  
> included in Forrest).

I suppose it is just the way that it evolved.

> Basic point for all these questions:
> 
> now we have copies of the same info all over the place, and most is  
> not used - I would like to remove all the unnecessary ones, and use LM  
> in all cases - and remove the messages from the seed. As part of that  
> I would like to update the user documentation for i18n as well, to  
> make sure it reflects the current state and how to set up proper i18n  
> support, as well as how to add new languages to the translation  
> catalogue.
> 
> WDYT?

I agree. Good on you for getting into this.
It is certainly needed.

-David